[quote=Ellri]
it eats them when the space is like this:
[color=fff200]Text[/color][color=8dc73f] here[/color]
[color=fff200]Text [/color][color=8dc73f]here[/color]
and not like this:
[color=fff200]Text[/color] [color=8dc73f]here[/color]
Just look at the raw code.
[/quote]
I see that the problem is that I modified the parser to trim all prefix/suffix whitespace from the contents of tags. ([url=https://github.com/danneu/guild/blob/7612d1467196e327584f1c63671a35109e1fda14/server/bbcode.js#L926]Source[/url])
It turns out that trimming whitespace makes sense 99% of the time.
When someone writes this:
[pre]
[quote]
hello
[/quote]
[/pre]
They generally mean this:
[pre][quote]hello[/quote][/pre]
Rather than this:
[pre]
[quote]
hello
[/quote]
[/pre]
After writing this out, I think the solution is to trim prefix/suffix line-breaks as usual, but rather than trimming prefix/suffix spaces, just collapse them into one space if they exist.
Maybe that will work. I'll let you know when I deploy a fix.
[quote=Captain Jordan]
I like that the Color Picker stays up so I can highlight and re-color another piece of text. Any thoughts about adjusting the hover so it doesn't obscure the text box (how about making it hover above the editor)?
Error checker is subtle and nice. I didn't notice it until I tried to purposely screw up a tag.
[quote]Quoting the right way.[/quote]
[quote=Mahz]Can I quote Mahz?[/quote]
[quote=http://www.roleplayerguild.com/posts/2345802]What about a quote with a link? Will it auto-link the text?[/quote]
Apparently not. I wonder if it'd be possible to add a linking function to quote, such as [noparse][quote name=Mahz link=2345802][/noparse] to link directly to the post in question. Quotes are easy to modify on your own (especially if quoting across topics) and sometimes the original context is useful.
[/quote]
- I used to have the color-picker on top but ran into a few minor issues. I'll put it back on top and just tackle the issues now that I have time to deal with them. Don't remember what the issues were.
- I'm going to modify the color-picker to drop in the color's name instead of the color's hex value. It's nicer to see color=Goldenrod and color=Tan instead of color=daa520 and color=d2b48c. Especially since we don't have a WYSIWYG editor. People will even have a shot at memorizing colors that they like to use.
- The error system is weak and is barely out of proof-of-concept phase, but I think I see a route to hacking in some line+column numbers which would set the stage for error highlighting (like underlining the problem). I have a proof of concept working by just counting newlines in a post-process step. But man, this bbcode parser file is getting nasty.
- I do want to extend quotes to include more optional metadata like [noparse][quote=Captain Jordan post=391823]...[/quote][/noparse]. In that case, as you'd expect, it'd link to the origin post.
I'll have a better sense of priorities once Sunday picks up and I see what people are struggling with.
Maybe I can put a dent in the notification system today.